Use sublocality when locality is missing - AddressSearch #5950

aldo-expensify · 2021-10-19T18:02:07Z

Details

There are addresses that have the component "locality" missing. We use the "locality" as the city. This PR will make us use the "sublocality" as the city when the "locality" is missing.

Fixed Issues

$ #5867

Tests / QA Steps

Create account in NewDot, verify it and log in
Create Workspace
Start add VBA flow and get to the "Company information" step (/bank-account/company)
Input in the "Company address" field: 64 Noll Street, Brooklyn, NY, USA and select the first (and only) result
Fill the rest of the fields
You should be able to continue to the next step without errors.

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

aldo-expensify · 2021-10-19T18:07:06Z

I completed the validations in validateAddressComponents because if an address has some missing fields, this gives a little better feedback for the user.

Do console.debug logging eventually reach our logging servers?

roryabraham

Do console.debug logging eventually reach our logging servers?

Nope, please use the Log library. See this PR.

aldo-expensify · 2021-10-19T22:13:44Z

Nope, please use the Log library. See this PR.

Thanks, I would think these logs are interesting enough to be sent to the server. They may eventually reveal other problematic cases that we don't know about, sounds correct?

aldo-expensify · 2021-10-19T22:22:04Z

Update: Changed console.debug for Log.hmmm

roryabraham

Log changes look good. Let's add some unit tests for this!

src/components/AddressSearch.js

aldo-expensify · 2021-10-20T00:13:31Z

Log changes look good. Let's add some unit tests for this!

Thanks for the review, I'll be looking into the testing stuff tomorrow to finish this up!

aldo-expensify · 2021-10-21T00:33:32Z

tests/unit/GooglePlacesUtilsTest.js

+                        types: ['postal_code'],
+                    },
+                ],
+                formatted_address: 'Quail Ridge Rd, Escondido, CA 92027, USA',


I left this here even if it not used in the tests just as a way to remember these addresses that gave up problems.

aldo-expensify · 2021-10-21T00:37:28Z

Update: Moved functions validateAddressComponents and getAddressComponent to lib/GooglePlacesUtils.js, added some tests for them in GooglePlacesUtilsTest.js

aldo-expensify · 2021-10-21T00:55:32Z

hmm, any ideas on why this could be happening?

TomatoToaster · 2021-10-21T14:52:26Z

Seems unrelated to your changes, @aldo-expensify, try merging the main branch into your PR, it might fix that issue.

…-for-missing-locality

aldo-expensify · 2021-10-21T17:26:47Z

@TomatoToaster thanks!, that worked :)

roryabraham

Thanks for adding these tests, that's huge. Just had some minor suggestions.

src/components/AddressSearch.js

src/libs/GooglePlacesUtils.js

aldo-expensify · 2021-10-22T23:32:09Z

Update:

Reorganized export
Replace arrow functions for regular functions
Add jsDoc to functions in GooglePlacesUtils
Add [AddressSearch] tag in Log.hmmm

roryabraham

Sorry, one last thing 😅

src/libs/GooglePlacesUtils.js

roryabraham · 2021-10-22T23:34:05Z

Also lint failure ^

aldo-expensify · 2021-10-22T23:35:13Z

Also lint failure ^

haha looking at that

…-for-missing-locality

aldo-expensify · 2021-10-22T23:44:04Z

Also lint failure ^

Ok, seems like the automatic merge was leaving the import _ from 'underscore'; out 🤷

roryabraham · 2021-10-22T23:46:34Z

Testing a feature of https://github.com/refined-github/refined-github:

Hopefully if E2E tests pass it will self-merge 🤞

aldo-expensify · 2021-10-22T23:48:38Z

Hopefully if E2E tests pass it will self-merge 🤞

nice 🤞

roryabraham · 2021-10-22T23:49:32Z

If it doesn't, feel free to self-merge.

OSBotify · 2021-10-23T01:42:25Z

🚀 Deployed to staging by @aldo-expensify in version: 1.1.8-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2021-10-28T20:56:07Z

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aldo-expensify added 2 commits October 19, 2021 10:51

Use sublocality when locality is missing

40ed45d

Add check on missing zip code and state

b07aa79

aldo-expensify requested a review from a team as a code owner October 19, 2021 18:02

MelvinBot requested review from danieldoglas and removed request for a team October 19, 2021 18:02

Add console.debug when address result is invalid

81317d4

roryabraham assigned aldo-expensify Oct 19, 2021

roryabraham requested changes Oct 19, 2021

View reviewed changes

Log bad addresses to server

ef09215

aldo-expensify mentioned this pull request Oct 19, 2021

VBA - Error message for manually entered address in the field in company info and unable to proceed #5841

Closed

roryabraham reviewed Oct 19, 2021

View reviewed changes

src/components/AddressSearch.js Outdated Show resolved Hide resolved

Refactor AddressSearch functions and add tests

ae984be

aldo-expensify commented Oct 21, 2021

View reviewed changes

Merge branch 'main' of github.com:Expensify/App into aldo_sublocality…

605a6aa

…-for-missing-locality

roryabraham requested changes Oct 22, 2021

View reviewed changes

src/components/AddressSearch.js Outdated Show resolved Hide resolved

src/components/AddressSearch.js Outdated Show resolved Hide resolved

src/libs/GooglePlacesUtils.js Outdated Show resolved Hide resolved

src/libs/GooglePlacesUtils.js Outdated Show resolved Hide resolved

aldo-expensify added 3 commits October 22, 2021 16:18

Reorganize exports

d49068f

Add [AddressSearch] to Log.hmmm

13d91cc

Add documentation to GooglePlacesUtils.js

23ad37f

roryabraham requested changes Oct 22, 2021

View reviewed changes

src/libs/GooglePlacesUtils.js Outdated Show resolved Hide resolved

aldo-expensify added 3 commits October 22, 2021 16:36

Rename address component validation function

0c844d9

Merge branch 'main' of github.com:Expensify/App into aldo_sublocality…

f14b2ec

…-for-missing-locality

Add missing import

62d6055

roryabraham approved these changes Oct 22, 2021

View reviewed changes

aldo-expensify merged commit e1ec61d into main Oct 23, 2021

aldo-expensify deleted the aldo_sublocality-for-missing-locality branch October 23, 2021 00:31

OSBotify mentioned this pull request Oct 23, 2021

Deploy Checklist: New Expensify 2021-10-23 #6017

Closed

bondydaa mentioned this pull request Jan 19, 2023

[HOLD for payment 2023-02-23] [$1000] Zipcode doesn’t update with a newly chosen location and remains unchanged #14324

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use sublocality when locality is missing - AddressSearch #5950

Use sublocality when locality is missing - AddressSearch #5950

aldo-expensify commented Oct 19, 2021

aldo-expensify commented Oct 19, 2021

roryabraham left a comment

aldo-expensify commented Oct 19, 2021

aldo-expensify commented Oct 19, 2021

roryabraham left a comment

aldo-expensify commented Oct 20, 2021

aldo-expensify Oct 21, 2021

aldo-expensify commented Oct 21, 2021

aldo-expensify commented Oct 21, 2021 •

edited

Loading

TomatoToaster commented Oct 21, 2021

aldo-expensify commented Oct 21, 2021

roryabraham left a comment

aldo-expensify commented Oct 22, 2021

roryabraham left a comment

roryabraham commented Oct 22, 2021

aldo-expensify commented Oct 22, 2021

aldo-expensify commented Oct 22, 2021

roryabraham commented Oct 22, 2021

aldo-expensify commented Oct 22, 2021

roryabraham commented Oct 22, 2021 •

edited

Loading

OSBotify commented Oct 23, 2021

OSBotify commented Oct 28, 2021

Use sublocality when locality is missing - AddressSearch #5950

Use sublocality when locality is missing - AddressSearch #5950

Conversation

aldo-expensify commented Oct 19, 2021

Details

Fixed Issues

Tests / QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

aldo-expensify commented Oct 19, 2021

roryabraham left a comment

Choose a reason for hiding this comment

aldo-expensify commented Oct 19, 2021

aldo-expensify commented Oct 19, 2021

roryabraham left a comment

Choose a reason for hiding this comment

aldo-expensify commented Oct 20, 2021

aldo-expensify Oct 21, 2021

Choose a reason for hiding this comment

aldo-expensify commented Oct 21, 2021

aldo-expensify commented Oct 21, 2021 • edited Loading

TomatoToaster commented Oct 21, 2021

aldo-expensify commented Oct 21, 2021

roryabraham left a comment

Choose a reason for hiding this comment

aldo-expensify commented Oct 22, 2021

roryabraham left a comment

Choose a reason for hiding this comment

roryabraham commented Oct 22, 2021

aldo-expensify commented Oct 22, 2021

aldo-expensify commented Oct 22, 2021

roryabraham commented Oct 22, 2021

aldo-expensify commented Oct 22, 2021

roryabraham commented Oct 22, 2021 • edited Loading

OSBotify commented Oct 23, 2021

OSBotify commented Oct 28, 2021

aldo-expensify commented Oct 21, 2021 •

edited

Loading

roryabraham commented Oct 22, 2021 •

edited

Loading