Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ResendValidation page #5961

Merged
merged 2 commits into from
Oct 23, 2021
Merged

fix: ResendValidation page #5961

merged 2 commits into from
Oct 23, 2021

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ #5942

Tests | QA Steps

  1. Lanch the app
  2. Enter a new account with a long email which hasn't been validated and Click Continue.
  3. Or use a validated account and click forget?.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Mobile Web | Desktop

image

iOS

Android

Screenshot 2021-10-20 21:18:41

@parasharrajat parasharrajat requested a review from a team as a code owner October 20, 2021 15:49
@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team October 20, 2021 15:49
@johnmlee101
Copy link
Contributor

Not sure why iOS tests are failing...

@parasharrajat
Copy link
Member Author

parasharrajat commented Oct 20, 2021 •
edited
Loading

@johnmlee101 It's happening on each PR.

current directory:
/Users/runner/work/App/App/vendor/bundle/ruby/2.7.0/gems/json-2.5.1/ext/json/ext/generator
make "DESTDIR="
xcrun: error: missing DEVELOPER_DIR path:
/Applications/Xcode_12.5.app/Contents/Developer

@parasharrajat
Copy link
Member Author

@johnmlee101 Waiting for your review.

@johnmlee101 johnmlee101 merged commit 7947449 into Expensify:main Oct 23, 2021
@OSBotify OSBotify mentioned this pull request Oct 23, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @johnmlee101 in version: 1.1.8-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Oct 28, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmlee101 johnmlee101 johnmlee101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@parasharrajat @johnmlee101 @OSBotify