Removes onTransitionEnd callback

[AlfredoAlc]

Details

Removes onTransitionEnd callback where the focus is set to TextInput.

Fixed Issues

$ #5403

Tests

1. Sign in to New Expensify with any account.
2. Navigate to Settings.
3. Click on Payments.
4. If no Paypal account is added, add one.
5. Click on Paypal account.
6. Verify that the name is not autofocused.

QA Steps

1. Sign in to New Expensify with any account.
2. Navigate to Settings.
3. Click on Payments.
4. If no Paypal account is added, add one.
5. Click on Paypal account.
6. Verify that the name is not autofocused.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

web.mov

Desktop

Desktop.mov

iOS

iOS.mp4

Android

Android.mov

[Luke9389]

@AlfredoAlc this is a small thing, but would you change the steps in the description to indicate what we want to see? Also it's nice to include a link to the site in step one for our QA testers. For example:

1. Sign in to new.expensify.com with any account
2. Navigate to Settings.
3. Click on Payments.
4. If no Paypal account is added, add one.
5. Click on Paypal account.
6. Verify that the name is not autofocused.

[Luke9389]

It doesn't look like the paypalUsernameInputRef is used anywhere else, so you can take it out of the constructor and the ExpensiTextInput.

[Luke9389]

Went to go see what's going on with the iOS test, looks like we have some versioning issues.

[Luke9389]

Not gonna merge this just yet. There's a discussion about the iOS tests here if you'd like to follow along: https://expensify.slack.com/archives/C01GTK53T8Q/p1634754414008400

[parasharrajat]

This PR is going against the issue and the proposal. It should place the cursor at the end instead of removing the autofocus.

cc: @Luke9389

[AlfredoAlc]

@parasharrajat It was later discussed that it would be better to remove the autofocus.
#5403 (comment)

[parasharrajat]

Thanks. Didn't see the other proposal.

[Luke9389]

I've got a PR up to fix the iOS tests. Once that's merged you should be able to pull master and we can get this squared away.

[AlfredoAlc]

@Luke9389 Thanks for keeping me updated!

[Luke9389]

Alright, @AlfredoAlc, you should be able to merge master and the tests will work.

[Luke9389]

@AlfredoAlc just want to double-check (I ask all my contributors this). Have you tested this since the last code change you made?

[parasharrajat]

LGTM based on new proposal.

[AlfredoAlc]

@Luke9389 Yes, I tested on all platforms.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @Luke9389 in version: 1.1.8-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅