[No QA] Bumping Xcode version to fix iOS tests failing on Travis #5970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luke9389
changed the title
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 21, 2021
Bumping Xcode version to fix iOS tests failing on Travis (cherry picked from commit 467d3b1)
|
🚀 Cherry-picked to staging by @roryabraham in version: 1.1.8-7 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
|
🚀 Deployed to staging by @Beamanator in version: 1.1.8-10 🚀
|
roryabraham
changed the title
|
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
iOS tests are failing, so we need to figure out how to fix em
One idea was to bump the XCode version found in e2e.yml
Slack discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1634754414008400
Evidence for bumping: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md#xcode
We'll see if the iOS tests pass here.
Edit: Looks like they did! I think we should be good to merge this.