[No QA] Clarify Onyx method usage in View #5999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thienlnam
previously approved these changes
Oct 22, 2021
README.md
Outdated
Comment on lines
156
to
157
| **Note:** As a convention, the UI layer should never interact with device storage directly or call `Onyx.set()` or `Onyx.merge()`. Use an action! | ||
|
|
There was a problem hiding this comment.
NAB: Linking to an example where we use an action instead of calling Onyx.merge/set
There was a problem hiding this comment.
Added an example with some permalinks and more explanation into the "why" (at least my interpretation of it). Lmk if it makes sense, sounds reasonable, etc 😄
|
🚀 Deployed to staging by @marcaaron in version: 1.1.8-12 🚀
|
roryabraham
changed the title
|
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
There are not too many usages here, but I cleaned them up by creating action methods.
Fixed Issues
$ #5998
Tests / QA Steps
All of these changes should be syntax and shouldn't have any bearing on the app behavior.
Therefore, we just need to run regular regressions.
Tested On