Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Add missing displayName. Remove unnecessary displayName. #6003

Merged
merged 2 commits into from
Oct 25, 2021
Merged

[No QA] Add missing displayName. Remove unnecessary displayName. #6003

merged 2 commits into from
Oct 25, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Oct 22, 2021 •
edited
Loading

Details

Add missing displayName to functional components and remove unnecessary displayName from class components.

Fixed Issues

$ #6002

Tests / QA Steps

All of these changes should be syntax and shouldn't have any bearing on the app behavior.
Therefore, we just need to run regular regressions.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@marcaaron marcaaron self-assigned this Oct 22, 2021
@marcaaron marcaaron changed the title Add missing displayName Add missing displayName. Remove unnecessary displayName. Oct 22, 2021
@marcaaron marcaaron marked this pull request as ready for review October 22, 2021 23:17
@marcaaron marcaaron requested a review from a team as a code owner October 22, 2021 23:17
@MelvinBot MelvinBot requested review from Gonals and removed request for a team October 22, 2021 23:18
Gonals
Gonals approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@Gonals Gonals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll keep an eye in the future in case we missed any, but it doesn't look like it!

@Gonals Gonals merged commit 0c749cf into main Oct 25, 2021
@Gonals Gonals deleted the marcaaron-missingDisplayName branch October 25, 2021 10:37
@OSBotify OSBotify mentioned this pull request Oct 25, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Gonals in version: 1.1.8-17 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@roryabraham roryabraham changed the title Add missing displayName. Remove unnecessary displayName. [No QA] Add missing displayName. Remove unnecessary displayName. Oct 25, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gonals Gonals Gonals approved these changes

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcaaron @OSBotify @Gonals