Fix duplicate comments posting related to Log calls from inside processNetworkRequestQueue()
#6043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reset in test helpers.
|
🚀 Deployed to staging by @sketchydroide in version: 1.1.9-2 🚀
|
|
This is a pass for me on staging.
|
5 tasks
|
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
There was some previous suggestion that a more long term solution to this is make report comments idempotent.
We should revisit that, but I think this bug is too obvious to not try to fix. The network code should never be calling
processNetworkRequestQueue()from insideprocessNetworkRequestQueue().Fixed Issues
$ #4214
Tests
QA Steps
This is difficult to test because a comment must be sent while there are 49 logs waiting to be sent.
So we can just make sure that comments can be sent normally and that no duplicates are appearing.
Tested On