Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Fix accessibility checkboxes in deploy checklist #6047

Merged
merged 6 commits into from
Oct 25, 2021
Merged

[No QA] Fix accessibility checkboxes in deploy checklist #6047

merged 6 commits into from
Oct 25, 2021

Conversation

roryabraham
Copy link
Contributor

cc @stitesExpensify @Julesssss

Details

Fixes the deploy checklist such that the checked/unchecked state of the accessibility checkboxes is preserved when the checklist is updated.

Does not fix issue where PRs are added to the checklist when they should not be.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/175521

Tests

Added/updated automated tests to cover these changes.

(internal) QA Steps

  1. Check off some accessibility boxes on the open checklist.
  2. Merge this PR.
  3. Verified that the checklist updates to include this PR and the new version, and that those boxes checked in step 1 remain checked.

@roryabraham roryabraham requested a review from a team as a code owner October 25, 2021 20:37
@roryabraham roryabraham self-assigned this Oct 25, 2021
@MelvinBot MelvinBot requested review from mountiny and removed request for a team October 25, 2021 20:37
mountiny
mountiny reviewed Oct 25, 2021
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must have been quite tedious. Great job! Left couple of comment about the [ x], just want to make sure it is like that on purpose and if yes, I would love to understand why 😅

.github/libs/GithubUtils.js Show resolved Hide resolved
.github/libs/GithubUtils.js Show resolved Hide resolved
@roryabraham
Copy link
Contributor Author

Updated!

@roryabraham roryabraham mentioned this pull request Oct 25, 2021
Closed
@roryabraham roryabraham merged commit baeb79d into main Oct 25, 2021
@roryabraham roryabraham deleted the Rory-FixAccessibilityChecklist branch October 25, 2021 23:02
@roryabraham
Copy link
Contributor Author

Let's see if this works, shall we?

@roryabraham roryabraham changed the title Fix accessibility checkboxes in deploy checklist [No QA] Fix accessibility checkboxes in deploy checklist Oct 25, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.9-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@roryabraham roryabraham mentioned this pull request Oct 25, 2021
Merged
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stitesExpensify stitesExpensify stitesExpensify approved these changes

@mountiny mountiny Awaiting requested review from mountiny

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roryabraham @OSBotify @mountiny @stitesExpensify