fix: New chat aren't showing bold in Left Hand Nav #6898

aswin-s · 2021-12-23T22:51:57Z

Details

This PR fixes an issue where new chat messages were not being shown in bold inside LHN.

Fixed Issues

$ #6874

Tests

Sign in as User A in one browser tab & as User B in another tab
Open chat with the other user in each tab.
Now navigate to a separate conversation in LHN for User B. (For example Concierge)
Send a message from User A to User B.
The new message should be highlighted in bold on the LHN for User B.
Verify that it works other way around as well.

QA Steps

Tested On

Screenshots

Web

fix_unread.mp4

Mobile Web

N.A

Desktop

iOS

Android

…AppState

marcochavezf

Looks good to me! cc @parasharrajat

OSBotify · 2021-12-27T18:33:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

marcochavezf · 2021-12-27T18:38:53Z

Merging it and applying the CP Staging label because more employees are going to experience this issue when are back from holidays.

github-actions · 2021-12-27T18:39:17Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

parasharrajat

Thanks for the changes @aswin-s and waiting for review I was on vacation. This looks good.

Could you please add videos for all platforms and present the following features;

The current issue.
Unread Message when the app is put to foreground from background.

parasharrajat · 2021-12-27T18:31:26Z

src/Expensify.js

@@ -134,7 +135,8 @@ class Expensify extends PureComponent {
    }

    componentWillUnmount() {
-        AppState.removeEventListener('change', this.initializeClient);
+        if (!this.appStateChangeListener) { return; }


Could you please expand this to multiple lines?

Suggested change

if (!this.appStateChangeListener) { return; }

if (!this.appStateChangeListener) {

return;

}

parasharrajat · 2021-12-27T18:35:04Z

src/Expensify.js

@@ -85,6 +85,7 @@ class Expensify extends PureComponent {
        ActiveClientManager.init();
        this.setNavigationReady = this.setNavigationReady.bind(this);
        this.initializeClient = this.initializeClient.bind(true);
+        this.appStateChangeListener = null;


Suggested change

this.appStateChangeListener = null;

parasharrajat · 2021-12-27T18:35:19Z

src/pages/home/report/ReportActionsView.js

@@ -106,6 +106,7 @@ class ReportActionsView extends React.Component {
        this.recordTimeToMeasureItemLayout = this.recordTimeToMeasureItemLayout.bind(this);
        this.loadMoreChats = this.loadMoreChats.bind(this);
        this.sortedReportActions = [];
+        this.appStateChangeListener = null;


Suggested change

this.appStateChangeListener = null;

aswin-s · 2021-12-27T19:17:30Z

@parasharrajat Should I raise a follow up PR with the suggested changes?

parasharrajat · 2021-12-27T19:27:35Z

These changes are no blocker for me so If @marcochavezf says we should do these then yeah please add a follow-up?

marcochavezf · 2021-12-27T19:59:33Z

These changes are no blocker for me so If @marcochavezf says we should do these then yeah please add a follow-up?

@parasharrajat Yeah, I think we could include these changes as a follow-up, thank you for doing it @aswin-s

roryabraham · 2021-12-28T18:45:07Z

Hi, I'm now seeing the following error on main:

roryabraham · 2021-12-28T18:52:57Z

It looks like this change was made in react-native 0.65, but we're still using react-native 0.64.1

roryabraham · 2021-12-28T19:01:58Z

I think we need to either revert this PR or upgrade the whole app to RN 0.65

aswin-s · 2021-12-28T19:14:38Z

@roryabraham as explained over here, removeEventListener was not working on react-native-web. I guess upgrading to 0.65 will solve it for both platforms, considering there is only a small diff between both versions.

https://react-native-community.github.io/upgrade-helper/?from=0.64.1&to=0.65.0

Related to this, I would also like to point out that dependencies like react-native-modal is also consistently throwing similar error on web which is fixed in their latest release. Unfortunately that dependency upgrade is also blocked by react-native peer dependency requirement of ">=0.65.0"

WDYT?

roryabraham · 2021-12-28T19:18:50Z

I suppose we should update react-native and the other dependencies that are throwing the error. I'll work on a pull request to upgrade RN.

roryabraham · 2021-12-28T21:17:56Z

I have an upgrade PR here, but I could use help testing it. Works well on iOS from my testing so far.

OSBotify · 2021-12-29T00:50:28Z

🚀 Deployed to staging by @marcochavezf in version: 1.1.23-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-01-04T01:34:28Z

🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aswin-s added 2 commits December 24, 2021 03:48

fix: LHN unread status for new messages

1fdc3e5

fix: Replace deprecated removeEventListener method with remove() for …

c1f0a49

…AppState

aswin-s requested a review from a team as a code owner December 23, 2021 22:51

MelvinBot requested review from marcochavezf and parasharrajat and removed request for a team December 23, 2021 22:51

marcochavezf approved these changes Dec 24, 2021

View reviewed changes

marcochavezf merged commit 22a7baf into Expensify:main Dec 27, 2021

marcochavezf added the CP Staging label Dec 27, 2021

parasharrajat suggested changes Dec 27, 2021

View reviewed changes

aswin-s deleted the aswin-s/issue_6874 branch December 27, 2021 18:45

aswin-s restored the aswin-s/issue_6874 branch December 27, 2021 18:51

roryabraham mentioned this pull request Dec 28, 2021

[No QA] Upgrade React Native to 0.66 #6914

Merged

5 tasks

OSBotify mentioned this pull request Dec 29, 2021

Deploy Checklist: New Expensify 2021-12-29 #6920

Closed

44 tasks

mananjadhav mentioned this pull request Dec 29, 2021

Android - White screen displayed after log out #6932

Closed

mallenexpensify mentioned this pull request Dec 31, 2021

[HOLD] The green unread message bar disappears too fast #6896

Closed

botify mentioned this pull request Jan 4, 2022

[HOLD for payment 2022-01-11] [$500] New chat aren't showing bold in Left Hand Nav (LHN) when received on desktop #6874

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: New chat aren't showing bold in Left Hand Nav #6898

fix: New chat aren't showing bold in Left Hand Nav #6898

aswin-s commented Dec 23, 2021

marcochavezf left a comment

OSBotify commented Dec 27, 2021

marcochavezf commented Dec 27, 2021 •

edited

github-actions bot commented Dec 27, 2021

parasharrajat left a comment

parasharrajat Dec 27, 2021

parasharrajat Dec 27, 2021

parasharrajat Dec 27, 2021

aswin-s commented Dec 27, 2021

parasharrajat commented Dec 27, 2021

marcochavezf commented Dec 27, 2021

roryabraham commented Dec 28, 2021 •

edited

roryabraham commented Dec 28, 2021

roryabraham commented Dec 28, 2021

aswin-s commented Dec 28, 2021

roryabraham commented Dec 28, 2021 •

edited

roryabraham commented Dec 28, 2021

OSBotify commented Dec 29, 2021

OSBotify commented Jan 4, 2022

fix: New chat aren't showing bold in Left Hand Nav #6898

fix: New chat aren't showing bold in Left Hand Nav #6898

Conversation

aswin-s commented Dec 23, 2021

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

marcochavezf left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 27, 2021

marcochavezf commented Dec 27, 2021 • edited

github-actions bot commented Dec 27, 2021

parasharrajat left a comment

Choose a reason for hiding this comment

parasharrajat Dec 27, 2021

Choose a reason for hiding this comment

parasharrajat Dec 27, 2021

Choose a reason for hiding this comment

parasharrajat Dec 27, 2021

Choose a reason for hiding this comment

aswin-s commented Dec 27, 2021

parasharrajat commented Dec 27, 2021

marcochavezf commented Dec 27, 2021

roryabraham commented Dec 28, 2021 • edited

roryabraham commented Dec 28, 2021

roryabraham commented Dec 28, 2021

aswin-s commented Dec 28, 2021

roryabraham commented Dec 28, 2021 • edited

roryabraham commented Dec 28, 2021

OSBotify commented Dec 29, 2021

OSBotify commented Jan 4, 2022

marcochavezf commented Dec 27, 2021 •

edited

roryabraham commented Dec 28, 2021 •

edited

roryabraham commented Dec 28, 2021 •

edited