Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweek verifying step header #7448

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Conversation

ctkochan22
Copy link
Contributor

@ctkochan22 ctkochan22 commented Jan 27, 2022

@Expensify/pullerbear

Quick copy change as per the comment in the issue
image

Details

Fixed Issues

$ #7322

Tests / QA Steps

Just test on Web is fine

  1. Follow https://stackoverflow.com/c/expensify/questions/342 to add a PENDING bank account

  2. When you get the PENDING state, verify that the title says "Test Transactions"

  3. Add another VBA that needs to be verified and is in the VERIFYING state

  4. When you get to the validationStep, verify that the title says "Validate Bank Account"

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@ctkochan22 ctkochan22 requested a review from a team January 27, 2022 21:39
@ctkochan22 ctkochan22 self-assigned this Jan 27, 2022
@MelvinBot MelvinBot requested review from yuwenmemon and removed request for a team January 27, 2022 21:39
Copy link
Contributor

@yuwenmemon yuwenmemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

@ctkochan22 ctkochan22 merged commit 7e6e7e8 into main Jan 27, 2022
@ctkochan22 ctkochan22 deleted the ckt_bankAccount_validationStepTitle branch January 27, 2022 22:44
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 1, 2022

🚀 Deployed to staging by @ctkochan22 in version: 1.1.33-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Feb 2, 2022

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants