-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable haptic feedback on the NumberPad #7827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good though it's hard to tell by testing on a sim. @parasharrajat I think your QA steps should say something about being sure to test this on a physical device and ensuring that haptic feedback actually occurs.
Oh yeah. You are correct, I forgot to add a device point. Doing now. |
Bump @NikkiWines . |
@parasharrajat, I'm confused. Your QA steps still don't mention anything about haptic feedback |
Sorry, Just added it. @NikkiWines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @NikkiWines in version: 1.1.41-0 🚀
|
🚀 Deployed to staging by @NikkiWines in version: 1.1.41-0 🚀
|
🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀
|
Details
Fixed Issues
$ #7128
Tests | QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android