Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable haptic feedback on the NumberPad #7827

Merged
merged 5 commits into from
Feb 24, 2022

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Feb 19, 2022

Details

Fixed Issues

$ #7128

Tests | QA Steps

  1. Open App on Android and IOS devices.
  2. Click FAB (:heavy_plus_sign: ).
  3. Open request money.
  4. Add some value via the number pad.
  5. All keys should have haptic/vibration feedback on each key press and on long press.
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

Android

image

@parasharrajat parasharrajat requested a review from a team as a code owner February 19, 2022 16:02
@MelvinBot MelvinBot requested review from NikkiWines and removed request for a team February 19, 2022 16:02
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good though it's hard to tell by testing on a sim. @parasharrajat I think your QA steps should say something about being sure to test this on a physical device and ensuring that haptic feedback actually occurs.

@parasharrajat
Copy link
Member Author

Oh yeah. You are correct, I forgot to add a device point. Doing now.

@parasharrajat
Copy link
Member Author

Bump @NikkiWines .

@NikkiWines
Copy link
Contributor

@parasharrajat, I'm confused. Your QA steps still don't mention anything about haptic feedback

@parasharrajat
Copy link
Member Author

Sorry, Just added it. @NikkiWines

Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NikkiWines NikkiWines merged commit d586981 into Expensify:main Feb 24, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 1, 2022

🚀 Deployed to staging by @NikkiWines in version: 1.1.41-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Mar 2, 2022

🚀 Deployed to staging by @NikkiWines in version: 1.1.41-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the hapticfeedbacl branch November 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants