Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove extra margin below checkbox #8017

Merged
merged 3 commits into from
Mar 8, 2022
Merged

remove extra margin below checkbox #8017

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebac29e
remove extra margin below checkbox
adeel0202 Mar 5, 2022
c87b0c8
replace margin top and bottom with margin vertical
adeel0202 Mar 5, 2022
460135f
consistent margin on top
adeel0202 Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/pages/EnablePayments/TermsStep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ class TermsStep extends React.Component {
)}
/>
<CheckboxWithLabel
style={styles.mb4}
isChecked={this.state.hasAcceptedPrivacyPolicyAndWalletAgreement}
onPress={this.togglePrivacyPolicy}
LabelComponent={() => (
Expand Down Expand Up @@ -107,7 +106,7 @@ class TermsStep extends React.Component {
)}
<Button
success
style={styles.mb4}
style={[styles.mb4, styles.mt4]}
adeel0202 marked this conversation as resolved.
Show resolved Hide resolved
text={this.props.translate('termsStep.enablePayments')}
isLoading={this.props.walletTerms.loading}
onPress={() => {
Expand Down
2 changes: 1 addition & 1 deletion src/pages/ReimbursementAccount/BankAccountStep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ class BankAccountStep extends React.Component {
errorText={this.getErrorText('accountNumber')}
/>
<CheckboxWithLabel
style={[styles.mb4, styles.mt5]}
style={styles.mt5}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update this to mt4 so they are all consistent.

isChecked={this.state.hasAcceptedTerms}
onPress={this.toggleTerms}
LabelComponent={() => (
Expand Down
2 changes: 1 addition & 1 deletion src/pages/settings/Payments/AddDebitCardPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ class DebitCardPage extends Component {
</TextLink>
</>
)}
style={[styles.mt4, styles.mb4]}
style={styles.mt4}
errorText={this.getErrorText('acceptedTerms')}
hasError={Boolean(this.state.errors.acceptedTerms)}
/>
Expand Down