Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the ready state of the welcome task #9132

Merged
merged 3 commits into from
May 24, 2022

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented May 23, 2022

Details

This was a simplification I noticed in the code

Fixed Issues

None

Tests & QA

  1. Log into chat as a brand new user that is not a member of any policies or workspaces
  2. Verify the create menu is open

@tgolen tgolen self-assigned this May 23, 2022
@tgolen tgolen requested a review from a team as a code owner May 23, 2022 17:14
@melvin-bot melvin-bot bot requested review from techievivek and removed request for a team May 23, 2022 17:15
@tgolen
Copy link
Contributor Author

tgolen commented May 24, 2022

Updated

@Luke9389
Copy link
Contributor

@techievivek, wanna take a look at this?

Copy link
Contributor

@techievivek techievivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I already had bit of luck looking at Tim's refactoring. 🙌

@techievivek techievivek merged commit d465ad0 into main May 24, 2022
@techievivek techievivek deleted the tgolen-simplify-welcome-ready branch May 24, 2022 17:46
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @techievivek in version: 1.1.67-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.67-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants