Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Fix Style on FullPageOfflineBlockingView #9269

Merged
merged 8 commits into from
Jun 6, 2022
Merged

[No QA] Fix Style on FullPageOfflineBlockingView #9269

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d8a08de
no period in you appear offline
Jun 1, 2022
2390aba
use a new vairable size instead of hard code
Jun 1, 2022
423ea9b
make that variable
Jun 1, 2022
39811d5
margin top on text
Jun 1, 2022
edbbc01
change font size
Jun 1, 2022
b7f07a2
new svg
Jun 1, 2022
0068d7c
fix text size conflict
Jun 1, 2022
0ca720c
changed icon variable name
Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/components/FullPageOfflineBlockingView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import * as Expensicons from './Icon/Expensicons';
import themeColors from '../styles/themes/default';
import styles from '../styles/styles';
import compose from '../libs/compose';
import variables from '../styles/variables';

const propTypes = {
/** Child elements */
Expand All @@ -31,10 +32,10 @@ const FullPageOfflineBlockingView = (props) => {
<Icon
src={Expensicons.OfflineCloud}
fill={themeColors.offline}
width={50}
height={50}
width={variables.iconSizeMondo}
height={variables.iconSizeMondo}
/>
<Text style={[styles.h1]}>{props.translate('common.youAppearToBeOffline')}</Text>
<Text style={[styles.h1, styles.mt5]}>{props.translate('common.youAppearToBeOffline')}</Text>
<Text style={[styles.w70, styles.textAlignCenter]}>{props.translate('common.thisFeatureRequiresInternet')}</Text>
</View>
);
Expand Down
2 changes: 1 addition & 1 deletion src/languages/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export default {
leaveRoom: 'Leave room',
your: 'your',
conciergeHelp: 'Please reach out to Concierge for help.',
youAppearToBeOffline: 'You appear to be offline.',
youAppearToBeOffline: 'You appear to be offline',
thisFeatureRequiresInternet: 'This feature requires an active internet connection to be used.',
},
attachmentPicker: {
Expand Down
2 changes: 1 addition & 1 deletion src/languages/es.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export default {
leaveRoom: 'Salir de la sala de chat',
your: 'tu',
conciergeHelp: 'Por favor contacta con Concierge para obtener ayuda.',
youAppearToBeOffline: 'Parece que estás desconectado.',
youAppearToBeOffline: 'Parece que estás desconectado',
thisFeatureRequiresInternet: 'Esta función requiere una conexión a Internet activa para ser utilizada.',
},
attachmentPicker: {
Expand Down
1 change: 1 addition & 0 deletions src/styles/variables.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export default {
iconSizeLarge: 24,
iconSizeXLarge: 28,
iconSizeExtraLarge: 40,
iconSizeMondo: 60,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does Mondo mean? I wonder if we should name this something more related to the usecase... like iconSizeFullPageOverlay or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about iconSizeSuperDuperLarge?

I don't think we should tie it to the use case because it may be used in a different situation where we aren't doing a full page overlay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to iconSizeSuperLarge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. Another approach we can take is that if we assume a default icon is 20x20, this particular icon is 3x that size.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current name (iconSizeSuperLarge) is fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I don't feel strongly but at some point it would be nice to clean up these variable names.

emojiSize: 20,
iouAmountTextSize: 40,
mobileResponsiveWidthBreakpoint: 800,
Expand Down