Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: false positive for no-document-import-in-page #151

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

fzhang13
Copy link
Contributor

@fzhang13 fzhang13 commented Sep 28, 2021

Jira Ticket ID:

What kind of change does this PR introduce? (check at least one)

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Code style update
  • Refactor (refactoring or adding test which isn't a fix or add a feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Did you test your solution?

  • I lightly tested it in one browser
  • I deeply tested it in several browsers
  • I wrote tests around it (unit tests, integration tests, E2E tests)

Problem Description

Solution Description

Side Effects, Risks, Impact

  • N/A

Aditional comments:

@fzhang13 fzhang13 merged commit 480bcd3 into main Sep 29, 2021
@DonghyukJacobJang
Copy link
Collaborator

I am hoping the fix should be arriving from NextJS soon. In my opinion, we should not have this by default and should apply this eslint rule per project when needed. The PR will be reverting.

@DonghyukJacobJang DonghyukJacobJang deleted the fix-linter-issue-no-document-import-in-page branch September 29, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Linter Issue - @next/next/no-document-import-in-page
3 participants