Added params callback to rescheduleIfNeeded #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Many javascript files included due to line ending differences. Source has CRLF and my local as LF (unix). There is an editorconfig file that sets LF as the line separator, so I don't know why all the JS files are using CRLF
steveklett
commented
Dec 14, 2023
| return () => { | ||
| const governanceRemains = governancePredicate(); | ||
| if (!governanceRemains) { | ||
| EC_Logger_1.DefaultLogger.warn('out of governance, rescheduling', task.create({ | ||
| const effectiveParams = paramsCallback ? paramsCallback() : params; | ||
| const taskID = task.create({ | ||
| taskType: task.TaskType.SCHEDULED_SCRIPT, |
There was a problem hiding this comment.
Broke this out to support a cleaner (IMO) logging call
| * @param minutes threshold for maximum number of minutes allowed to elapse. | ||
| * Note: If not setting a minute value, pass {undefined} or a very high minute value. Using {null} will | ||
| * create undesired behavior (i.e., it will return false when comparing the elapsed time to null) | ||
| * |
There was a problem hiding this comment.
This got me - I was passing null and kept having premature rescheduling. Finally figured out elapsed > null will return true as null is coerced to 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves request #86
governanceRemains()comments, cautioning against usingnullfor skipped parameters