Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

Loop task can be set to a timestamp #28

Closed
ghost opened this issue Jan 10, 2019 · 7 comments
Closed

Loop task can be set to a timestamp #28

ghost opened this issue Jan 10, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Jan 10, 2019

It would be great if the loop task had an option to set a timestamp, so that it would keep looping until that specific time.
Could either be with a specific date or just a time of the day.

@ghost
Copy link
Author

ghost commented Jan 10, 2019

@masterofhash do you think this would be possible to be implemented?

@Explv
Copy link
Owner

Explv commented Jan 10, 2019

This shouldn't be hard, we'll need to make sure the GUI changes are backwards compatible in terms of JSON serializing / deserializing to ensure it doesn't break people's existing saved configs

@Master-Of
Copy link
Contributor

Yeah that's true. Would you want to do a full loop or check the time at each step in the loop and short circuit the loop @realpoke ?

@ghost
Copy link
Author

ghost commented Jan 10, 2019

I think it would be best to have it stop as soon as it hits the timestamp, so to short sircuit the loop would be great if possible :D

@Master-Of
Copy link
Contributor

Master-Of commented Jan 10, 2019

Oh okay, I was thinking the "Stop at end of loop" approach. I'm good with either one, though. We could also have a "Timestamp" input and an "Interrupt Loop" checkbox button?

@Explv
Copy link
Owner

Explv commented Jan 10, 2019

I think timestamp and an interrupt option makes the most sense here.

@Master-Of
Copy link
Contributor

Master-Of commented Jan 10, 2019 via email

@Explv Explv added the enhancement New feature or request label Jan 10, 2019
@Explv Explv changed the title Request: Loop task can be set to a timestamp Loop task can be set to a timestamp Jan 10, 2019
@Explv Explv closed this as completed in b5b7c65 Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants