Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cleanup + Adding JSON Schemas for plugin/policy #1

Merged
merged 2 commits into from Oct 23, 2018
Merged

Test cleanup + Adding JSON Schemas for plugin/policy #1

merged 2 commits into from Oct 23, 2018

Conversation

kevinswiber
Copy link
Member

@kevinswiber kevinswiber commented Oct 18, 2018 •
edited

Connects LunchBadger/general#498.

@kevinswiber
Changing basic in tests to proxy.'
fce227e 
Signed-off-by: Kevin Swiber <kswiber@gmail.com>
@kevinswiber
Adding schemas.
79b4422 
Signed-off-by: Kevin Swiber <kswiber@gmail.com>
DrMegavolt
DrMegavolt approved these changes Oct 22, 2018
View reviewed changes
Copy link

@DrMegavolt DrMegavolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinswiber kevinswiber merged commit 87d5d92 into master Oct 23, 2018
@kevinswiber kevinswiber deleted the cleanup branch October 23, 2018 16:36
@kevinswiber kevinswiber removed the test label Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrMegavolt DrMegavolt DrMegavolt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinswiber @DrMegavolt