add comments

ExpressLRS · Feb 2, 2022 · de63704 · de63704
1 parent 54fd64c
commit de63704
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/lib/CONFIG/config.h b/src/lib/CONFIG/config.h
@@ -129,7 +129,8 @@ typedef struct {
     uint8_t     powerOnCounter;
     uint8_t     modelId;
     uint8_t     power;
-    uint8_t     antennaMode;
+    uint8_t     antennaMode;    //keep antenna mode in struct even in non diversity RX,
+                                // because turning feature diversity on and off would require change of RX config version.
     char        ssid[33];
     char        password[33];
     rx_config_pwm_t pwmChannels[PWM_MAX_CHANNELS];

diff --git a/src/lib/LUA/rx_devLUA.cpp b/src/lib/LUA/rx_devLUA.cpp
@@ -65,14 +65,14 @@ static void registerLuaParameters()
 #if defined(GPIO_PIN_ANTENNA_SELECT) && defined(USE_DIVERSITY)
   registerLUAParameter(&luaAntennaMode, [](uint8_t id, uint8_t arg){
       config.SetAntennaMode(arg);
-      config.Commit();
+      config.Commit();// this commit doesn't trigger restart
       devicesTriggerEvent();
   });
 #endif
 
 registerLUAParameter(&luaTlmPower, [](uint8_t id, uint8_t arg){
     config.SetPower(arg);
-    //config.Commit();
+    //config.Commit(); this commit trigger restart
     if(arg == 0){
       POWERMGNT.setPower(MinPower);
     } else {