Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen flashes unexpectedly when running elrsV3 Lua script #2669

Closed
RC-SOAR opened this issue Apr 20, 2024 · 22 comments
Closed

Screen flashes unexpectedly when running elrsV3 Lua script #2669

RC-SOAR opened this issue Apr 20, 2024 · 22 comments
Labels
closing 🚪 Will close if no new information is reported

Comments

@RC-SOAR
Copy link

RC-SOAR commented Apr 20, 2024

Current Behavior

When running elrsV3 script on my TX16S under OpenTX 2.3.15, the screen flashes rapidly after each click or scroll increment, which is distracting. Video here:

https://youtu.be/WO_e5PuhHwU?si=PkAvhA9-y2YpKBXa

The actual link with the rx works fine.

Is there a Lua fix for this?

(I notice that the "configure Crossfire" script in the Tools menu provides similar functionality and doesn't suffer from the flashing issue.)

Steps to Reproduce

  1. Go to OpenTX Tools menu
  2. Run ELRSv3 script

Your Environment

RM TX16S
OpenTX 2.3.15
Ranger Micro external ELRS 3.3.0

@pkendall64
Copy link
Collaborator

This looks like an openTX bug as this does not happen on EdgeTX with the same Lua script.

@RC-SOAR
Copy link
Author

RC-SOAR commented Apr 21, 2024

Further data point... version 3.2 of the script works fine (after selecting '3.2' release in the configurator and downloading the script). So an incompatibility has crept in with the 3.3 script.
It would be great if this were investigated as there are still many OTX users out there.

@aerostarlegacy
Copy link

Hello! This is effecting me as well.

@JyeSmith
Copy link
Member

OTX is no longer maintained or supported. The fix here is to update to EdgeTX.

@JyeSmith JyeSmith added the closing 🚪 Will close if no new information is reported label Apr 24, 2024
@RC-SOAR
Copy link
Author

RC-SOAR commented Apr 24, 2024

Confused, as ELRS apparently supports OpenTX 2.2.12 or newer as in:
https://www.expresslrs.org/quick-start/transmitters/tx-prep/#internal-expresslrs-modules
The closing of this issue appears to contradict this.

In the meantime, I worked around this by using the 3.2 script (as advised on Discord). Seems to work, but I have no idea what's changed.

@pkendall64
Copy link
Collaborator

The changes from the 3.2 script are basically to add support for Ardupilot and some optimisations to reduce memory usage for memory limited radios, some fixes to better support configuration of PWM receivers and reducing screen update so it loads faster (this was because of change in the EdgeTX graphical library).
So if the older version works for you then just keep using it.

@github-actions github-actions bot removed the closing 🚪 Will close if no new information is reported label Apr 25, 2024
@RC-SOAR
Copy link
Author

RC-SOAR commented Apr 25, 2024

Thanks Paul. Given that there are still lots of OTX users out there it would be great if compatibility were maintained if poss, though I appreciate it's an increased maintenance burden for you guys.

@aerostarlegacy
Copy link

@RC-SOAR - can you post a link to that 3.2 script here so others might find it?

@RC-SOAR
Copy link
Author

RC-SOAR commented Apr 25, 2024

@aerostarlegacy I downloaded it via the Configurator, after selecting the 3.2 target.

@CapnBry
Copy link
Member

CapnBry commented May 23, 2024

Given that there are still lots of OTX users out there it would be great if compatibility were maintained if poss

Why are they still on OTX? EdgeTX is available for all OTX targets. OpenTX is dead and EdgeTX has replaced it.

@CapnBry CapnBry added the closing 🚪 Will close if no new information is reported label May 23, 2024
@RC-SOAR
Copy link
Author

RC-SOAR commented May 23, 2024

OTX on a TX16S is much more productive when dealing with setups with 60 or so mixers as is not uncommon with sailplane setups like my F5J template

@mha1
Copy link
Contributor

mha1 commented May 24, 2024

What do you mean by productive?

@github-actions github-actions bot removed the closing 🚪 Will close if no new information is reported label May 24, 2024
@RC-SOAR
Copy link
Author

RC-SOAR commented May 24, 2024

What do you mean by productive?

The menus in OTX are denser, so less scrolling and swiping, and the Mixers menu caters well for complex setups - it's quick and easy to navigate.
The Mixers menu in ETX is especially awkward to manage - the UI is slow and tedious. It's as if ETX was designed primarily for use with FCs requiring just a handful of mixers.
All this applies to the colour screen radios only, the non-touch mono screen interface is fine.

@pkendall64 pkendall64 added the closing 🚪 Will close if no new information is reported label Jun 6, 2024
Copy link

This issue was closed because it has been inactive for 12 days since being marked as closing.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2024
@macgyverek
Copy link

Added fix on my repo for that issue: https://github.com/macgyverek/ExpressLRS-LUA-OpenTx

@RC-SOAR
Copy link
Author

RC-SOAR commented Aug 31, 2024

Thanks for this. Out of interest, can you point to the corrected lines of code?

@macgyverek
Copy link

Yes, no problem:
LUA Fix

@RC-SOAR
Copy link
Author

RC-SOAR commented Aug 31, 2024

It would be nice if the fix could be applied to the production version. Any chance?

@CapnBry
Copy link
Member

CapnBry commented Sep 1, 2024

It would be nice if the fix could be applied to the production version. Any chance?

Nope, because making that change absolutely crushes performance on EdgeTX. It redraws the whole screen every update which is crazy slow on EdgeTX to the point it takes 2-3x longer for the list to load.

@macgyverek
Copy link

But you can use version checker and write if/else for edgetx, opentx. But I know...developers are very stubborns ;)

@CapnBry
Copy link
Member

CapnBry commented Sep 3, 2024

But you can use version checker and write if/else for edgetx, opentx. But I know...developers are very stubborns ;)

There's incredibly low RAM available on many platforms the lua runs on. Having the script try to detect and run two different ways is a waste of resources that it doesn't have. Maybe complain to the OpenTX team about the bug causing the screen to clear between every update?

Feels more like someone could just update their supported hardware to a version of EdgeTX and resolve this themselves, but users are very stubborns about solving their own problem ;) And why doesn't the Configurator support Windows Me?! 😆

@macgyverek
Copy link

macgyverek commented Sep 3, 2024

EdgeTx it's crappy for user with colour screen without touch screen...like x10s, x12s... It's a very good radio, not like "Chinese" Jumper...

More information are showed on screen with OpenTX.
It's not update decision....if edgetx will make a screen (GUI) like in opentx, I will update today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closing 🚪 Will close if no new information is reported
Projects
None yet
Development

No branches or pull requests

7 participants