Rename and use define for radio chip #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than relying on regulatory domain which should only be used for FHSS
CapnBry
reviewed
Feb 12, 2022
pkendall64
force-pushed
the
define-radio-chip
branch
from
7d3c886
to
33299e2
Compare
cruwaller
reviewed
Feb 14, 2022
cruwaller
reviewed
Feb 14, 2022
cruwaller
approved these changes
Feb 14, 2022
cruwaller
approved these changes
Feb 14, 2022
CapnBry
approved these changes
Feb 24, 2022
StonedDawg
pushed a commit
to StonedDawg/ExpressLRS
that referenced
this pull request
Feb 27, 2022
* Define radio chip in target Rather than relying on regulatory domain which should only be used for FHSS * Move radio define to ini files * Add missing =1 * Change RADIO_SX1280 to RADIO_SX128X
StonedDawg
pushed a commit
to StonedDawg/ExpressLRS
that referenced
this pull request
Feb 28, 2022
* Define radio chip in target Rather than relying on regulatory domain which should only be used for FHSS * Move radio define to ini files * Add missing =1 * Change RADIO_SX1280 to RADIO_SX128X
pkendall64
added a commit
that referenced
this pull request
Feb 28, 2022
* initial device ping work * working on other data type ugly code base but working fix conflict cleanup before it gets messy * populate real RX params * Add antenna Mode * clean up useless luaitem clean up more cleanup more cleanup enlarge packet size * crude work for rf power (only lua params) fix lua power config * need to measure output, also start on other rxes add the other rxes * change power work but config.commit crashes? * add comments * merge back lua.cpp * use power array add others ower array * "Fixes" for crashing when commiting config * Add Pause/Resume on SX127x * cleanup and add other rxes * resolve conversation * just re-ordering defines and white space cleanup * add back mis-deleted function * Revert "Add Pause/Resume on SX127x" and fix commit properly This reverts commit aef1efb. * Rename and use define for radio chip (#1425) * Define radio chip in target Rather than relying on regulatory domain which should only be used for FHSS * Move radio define to ini files * Add missing =1 * Change RADIO_SX1280 to RADIO_SX128X * we got stray #endif * remove domain_reg_2400 defines * Add deferred execution in LUA * Add missing include Co-authored-by: Paul Kendall <pkendall64@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a lot of places we are using the regulatory domain as a surrogate for the radio chip. So rather than using the regulatory domain, I've renamed the RADIO_900/2400 defines in the .ini files to RADIO_SX127X/SX1280. In most places where there were checks for Regulatory_Domain_* they have been changed to check the appropriate radio chip define.
The only places left checking for specific regulatory domains are EU_CE_2400 for LBT specific code paths, some _868 ones for different power values in some targets, and the FHSS tables.
This PR is part of the larger goal to build a "single" for each target. Actually two for 2G4, FCC and LBT.