Bump to share #1510
Bump to share #1510
Conversation
|
I'm trying to test this and I am smacking the heck out of my radios (Axis Thor on one) with the antennas pointing up w/ a RX connected and it never goes into binding mode. Is there some other criteria I am missing? Using "Loan Model" from the Lua works, but I can't seem to get a proper bump out of it. Maybe I don't know what a bump is? To me it means moving the backs (module side) toward each other until they hit each other. I've done it a lot harder than someone with a $140 ExpressLRS module probably ever should. Oh snap they're on sale $95 now! (smacks the heck out of it recklessly) |
I just knock it on the side with my knuckle! |
|
Tested this with axis bound to jumper RX, all is working as it should.... was only a tap with my finger! |
There was a problem hiding this comment.
I evaluated this again after manually repulling the PR and bumps work for me!
However, now when I put my radio down on the table (standing up because the massive Thor module means it can't lay down) it goes into loan mode, if I pick it up too quickly, it goes into loan mode, if I hit my right hand too hard with the controller as I prepare to use it or my finger taps the radio body, it goes into loan mode. Is there any way to reduce the sensitivity?
This is a fun idea but I'm really concerned about it being a nuisance. It is really easy to activate for a function that will be so rarely used.
|
Any comments about the other points I've made? There's still some pending conversations in the "Files changed" view |
|
This looks good, but do you want to maybe tie it to
|
Good ideas, implemented. |
# Conflicts: # src/lib/CONFIG/config.cpp
# Conflicts: # src/lib/GSENSOR/devGsensor.cpp # src/src/rx_main.cpp # src/src/rxtx_common.cpp
|
What's going on developers! Poor PK has been waiting for your approval for over a month! I still stand by my approval. |
# Conflicts: # src/src/rx_main.cpp
What a disaster that would have been 😓 |
* bump/tap detection on accelerometer * Log the g-sensor data at the end of bumping Add float logging * Allow single bump transfer if the radio is in the upright position * Move deferred function calling to rxtx_common * STM32 has no room left when debugging * Changes as per review * More cleanup as per review * Tie the bump-to-share function to having motion detection enabled * Don't do bump loan/bind if armed!
This PR is an extension to the "Loan Model" functionality for transmitter modules with an accelerometer.
The person who is loaning their model must be connected to the model that wish to loan out.
With your radios in an upright position (i.e. antenna facing the sky) bump the radios together. The lender's module will send the "Loan Model" command to the RX and the borrower's TX module will start binding. If all goes well, the model is loaned to the borrower.
To return the model, the borrower uses the LUA script to "Return Model" or the owner power cycles 3 times, as per the "Loan Model" functionality.