Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sync on arm #156

Closed
wants to merge 29 commits into from
Closed

No sync on arm #156

wants to merge 29 commits into from

Conversation

AlessandroAU
Copy link
Member

For racing, adds option to skip sync packets after quad is armed. Better RC data and quicker syncs

@JyeSmith
Copy link
Member

A few other random changes in here 😑

Ill test fly this on the weekend, but previously hacked together nosync code has worked well,

@JBKingdon worthwhile updating the switch packets to send the arm aux every packet when defined?

@@ -715,20 +723,29 @@ void loop()
}
else
{
#ifdef NO_SYNC_ON_ARM
CURR_RATE_MAX = 4; //switch between 200hz, 100hz, 50hz, rates
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is the same as the original one - one of them must be wrong?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CURR_RATE_MAX = 4 breaks 2.4 as it only has 3 air modes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see Sandro snuck a commit in to fix this 345fe01

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup fixed

@JBKingdon
Copy link
Collaborator

@JBKingdon worthwhile updating the switch packets to send the arm aux every packet when defined?

Ah, you mean now that the channel used for arm is configurable via

-DARM_CHANNEL=5

Yes, that would be a good change to make. I created issue #157 to document it.

@@ -15,7 +15,7 @@
### STEP1: ###
### Enable one of these regulatory domains by removing a leading '#' ###

#-DRegulatory_Domain_AU_915
-DRegulatory_Domain_AU_915
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should commented by default

@AlessandroAU AlessandroAU deleted the no_sync_on_arm_testing branch November 19, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants