More robust firmware upload #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkendall64
force-pushed
the
more-robust-wifi-update
branch
from
0c51dbf
to
3e4e5bc
Compare
wvarty
approved these changes
May 7, 2022
|
Set TX into wifi update via AP, and then moved it to the edge of the wifi range, right before it dropped the wifi connection to the PC. |
FOG-Yamato
approved these changes
May 7, 2022
This was referenced May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was explaining to user on discord how the wifi updates work I realised there was a case where a bad flash could occur!
This PR fixes that case by passing the size of the firmware file in a HTTP header that the device will use to pass to the updater. This means that once the upload is complete we can check with the updater class that it has received all the expected data and if not then the update can be cancelled and an error returned to the user.
Previously we set the updater expected size to as much free space as we had (or unlimited on ESP32) and at the end just blindly told the updater to go ahead!