Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix streamexpect install dependency issue #1564

Conversation

pkendall64
Copy link
Collaborator

This back-ports the inclusion of streamexpect into the ExpressLRS code base, therefore not requiring a pip install which cause the breakage because the setup.py for streamexpect depended on setuptools-markdown which depended on pypandoc which got upgraded in an incompatible way and all the dependencies are >=, which is "problematic".

@pkendall64 pkendall64 changed the base branch from master to 2.x.x-maintenance May 11, 2022 04:27
@deadbytefpv
Copy link
Contributor

Suggested this PR for quite a few users within the day and they were able to build and flash their devices.
Thanks PK!

@YQBen
Copy link

YQBen commented Jun 23, 2022

Sorry I'm new to this, I also got the erro that module 'pypandoc' has no attribute 'convert', looks like the solution is here, is the thing I should do to add the 3 .py files into the src folder and try to build again? I tried and got this
ModuleNotFoundError: No module named 'external':

em... sorry again for such a basic question.

@deadbytefpv
Copy link
Contributor

Sorry I'm new to this, I also got the erro that module 'pypandoc' has no attribute 'convert', looks like the solution is here, is the thing I should do to add the 3 .py files into the src folder and try to build again? I tried and got this ModuleNotFoundError: No module named 'external':

em... sorry again for such a basic question.

You should be building 2.5.0 (or the latest 2.5.1) firmware now as the fix for this issue is already there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants