Display warning/error when changing packet and baud-rate too low #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvarty
approved these changes
Jul 4, 2022
There was a problem hiding this comment.
Tested on RM Zorro
GIVEN baud is 400k
WHEN the 1000hz option is selected in LUA
THEN the LUA shows the error message
PASS
GIVEN baud is 5.75M
AND the handset has been rebooted after changing baud
WHEN the 1000hz option is selected in LUA
THEN the rate changes to 1000hz, and the error message is not shown
PASS
GIVEN baud is 5.75M
AND the current rate is 1000hz
WHEN the baud is changed to 400k
AND the handset is rebooted
THEN the rate is F500
PASS
|
What Wez said, but with a TLite. |
JyeSmith
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a user changes the packet rate and the baud rate is too low, the packet rate doesn't "stick" and the user thinks it's a bug.
Solution
Display an error/warning message so the user is aware that the baud rate is too low.