Fix for failed g-sensor #1698
Merged
Fix for failed g-sensor #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JyeSmith
approved these changes
Jul 18, 2022
|
I found the underlying cause of my problem #1700. |
|
@pkendall64 Ill leave it to you if you want to re label this PR. But I think it still catches a potential issue that could pop up unexpectedly. |
So we may as well leave it for 3.0 then |
brandonrc
approved these changes
Jul 19, 2022
FOG-Yamato
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the g-sensor fails (as they do) then we shouldn't be trying to read from it anymore as it has a huge timeout and the entire module becomes unusable!
This fix is to check the status of the g-sensor on startup and remember if it's ok and only use it if it was deemed to be working at initialisation time. i.e. if we managed to read a valid chip-id.