Adjust PWMPEX vbat_scale with testing results #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the vbat_scale for 6ch PWMPEX receivers with a value obtained from testing with 2x R24-P6 samples provided by Matek. The values tracked from 3.5V to 31.0V exactly in bench testing after this adjustment. 3.0V read as 3.1V but I didn't want to try to mess with it after 310 flippin' nailed the other more than 25 test points. 馃 The 7ch is adjusted too, but that target doesn't work currently.
The divider 33k/1k should be 301 per Matek_Sampson, we had 299, but that read too high for me-- 11.35V read as 11.8V. This is something that obviously could be slightly different per batch or temperature (testing was performed at 26C) and can be changed in hardware.html.
Post-3.0 we can work this into the Lua or something better (dedicated webui field?). I've already got space set aside in the config struct to override the hardware definition.