New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EMAX targets #1787
Add EMAX targets #1787
Conversation
I'm trying to test this on the EMAX OLED TX and it keeps locking up when I change the power level. EDIT: Actually it keeps locking up changing virtually any item in the Lua... The output power doesn't go below 35mW either, so shouldn't this be one that starts at 25mW? |
I've remeasured mine now that I have a IRC power meter and it goes down to 11-12 dBm, so about 15mW on the 10mW setting. I have seen a lockup but it's certainly not all the time, but I'll look into that. |
@CapnBry I've tracked the lockup to a bug in the platform I2C code. It's the reason the Axis module was also locking up with the thermal device. I do not think it would wise to upgrade the platform at this late stage in the 3.0 release cycle, but we could upgrade early in 3.1. |
I guess you didn't make this change? I keep getting lockups changing config through the Lua, and my power values are still all over the place even after Sunjun's calibration. I did find that my meter was on 5650MHz in the first test (/shame), but now on 2400 peak with a 10dBm attenuator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basic functional testing looks ok to me. Approving this after discussing the lockup issues raised above in comments, and agreeing that these are not specific to Emax targets, so should not hold up the merge.
Adds EMAX 2.4GHz and 900MHz targets: