Disable TX diversity on FM30 #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JyeSmith
approved these changes
Oct 18, 2022
|
Reporting user aMax on Discord / RC Groups also reports this fully resolves their terrible signal issue. Thanks for the quick reviews! |
qqqlab
pushed a commit
to qqqlab/ExpressLRS
that referenced
this pull request
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables diversity switching on the TX on SIYI FM30 hardware, which is causing major issues by transmitting half the packets to a disconnected antenna u.FL.
Details
The PR which unified the ANT_CTRL defines enables TX diversity on any TX target that has this set. However, the FM30 has this set but only has one physical antenna attached so this started sending 50% of the packets out the second, disconnected antenna.
I did not notice this because I have added a second internal antenna to my FM30 so it was not obvious in testing as the RSSI reported is smoothed and will just show a lower average.
Target Branch
I dunno what is supposed to go on what branch, but this is a bug fix for 3.0.1 so it is against 3.x.x-maint. It should also apply cleanly to master if I should need to rebase it, or just flippin retype the 20 characters this patch is.