Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PWM RX lua #1962

Merged
merged 1 commit into from Nov 24, 2022
Merged

Conversation

pkendall64
Copy link
Collaborator

Moving the folder elements to the end of the LUA code fixes the problem.
I think this is a workaround as I believe the root of the problem is actually in the Lua script.

@gjhaynes
Copy link

No LUA error on Matek R24-D with this pull request. Channel mapping works. Tx Module running 3.0.1.

@JyeSmith
Copy link
Member

Tested in a mashup of current PRs.

I wasnt having issues, but this PR still look fine on a Pico PWM Rx.

@ajjjjjjjj
Copy link
Contributor

ajjjjjjjj commented Nov 23, 2022

I have tested previous revision again just to make sure that Serial speed or Packet Rate have any influence on that but no.
After flashing this revision error went away.

Regarding your comment on Lua:
I'm not using Lua but custom C implementation (based on Lua) and error was exactly in the same place as it was in Lua and now is gone.

@wvarty
Copy link
Collaborator

wvarty commented Nov 24, 2022

Tested on:

  • TX16S internal
  • HM EPW5

Confirmed I could reproduce the syntax error on a different branch, flashed this branch and error no longer occurs.
Good to go.

@JyeSmith JyeSmith merged commit dfa7d82 into ExpressLRS:3.x.x-maintenance Nov 24, 2022
@paulkidd68
Copy link

Tested

.TX16s with BetaFPV external
.BetaFPV PWM rx

Flashed with the Maintenance branch and all working.

@pkendall64 pkendall64 deleted the fix-rx-pwm-lua branch December 6, 2022 18:21
qqqlab pushed a commit to qqqlab/ExpressLRS that referenced this pull request Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LUA Script error on PWM Receiver
6 participants