New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for /config
on 8285 based devices
#2026
Conversation
Tested with both an EP1 and an RP3 that wouldn't show any config parameters on previous master (1d58dca) |
This works on:
However, if everything fits in 2KB on all platforms, why is it allocating 32KB at all? Also the allocation of I missed where the model configurations export were added, but the button calls them "model configurations" and the import line below them call them "models configuration", so which is it? 😅 It would have been smarter at the time to not spell-out-every-parameter-in-the-longest-way-possible 64 times, to save RAM allocation and minor code space. Can we change this before 3.2? RAM is a limited resource and this is just shooting itself in the foot. |
I'm not sure how you'd want to minimise the parameter names. JSON is a bit wordy, but I wanted to keep the file at least semi human readable. The export code is only running on TX modules, which are ESP32 and they have 520kb of RAM, so plenty to go around. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a lot of 3.2 testing with this PR. No probs.
I just feel like there's always "plenty of RAM" until there isn't and someone needs to change the one thing that pushed it over the limit instead of optimizing along the way. Things like the Anyway, that's all only tangential to this so, working is better than not working. Tested on a couple other rando things over the weekend too. |
* Fix for /config on 8285 based devices * Fix naming of button/upload text
8285 devices don't have enough memory (RAM) to allocate a 32k JSON object! And we don't need that much on an RX anyway.