Fix attenuation for some ESP32 pins #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix scale when checking low voltage scenarios
CapnBry
approved these changes
Mar 29, 2023
JyeSmith
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the testing of a new target, it was found that some ADC pins are not using the 0dB attenuation that we have set our code up for, so this always sets the attenuation to 0dB for ADC pins used for VBAT measurement on ESP32 devices.
Also whilst testing said new target, it was found that at low voltages (1S i.e. 3.8V) the VBAT code was setting it to zero. This was simply a bug using the wrong scale value for the cutoff calculation. As the median calculator discards the min/max values from it's calculation so the sum is actually based on the MedianAvgFilter's scale NOT the configured number of elements in the moving average window.