Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RF power-creep on TTGOv2 TX #2167

Merged
merged 1 commit into from Apr 14, 2023
Merged

Fix RF power-creep on TTGOv2 TX #2167

merged 1 commit into from Apr 14, 2023

Conversation

wvarty
Copy link
Collaborator

@wvarty wvarty commented Apr 14, 2023

When using a TTGOv2 dev board as a TX, the RF power slowly increases of it's own accord, as if dynamic power is turned on, even though it is not.
This is a result of a define in the target file for the button pin, which is typically connected to the 5way selector on a module that has a screen.
The unused button pin was floating, and thus triggering random false "presses", which I assume is changing settings and cause power to increase.
Removing the define in the TX target for TTGO has fixed the problem in my testing.
Screenshot_7

@wvarty wvarty requested a review from JyeSmith April 14, 2023 12:34
Copy link
Collaborator

@pkendall64 pkendall64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default button action is long-press = increase power. So if there is no button then it could easily do as you say. The pin is defined as INPUT_PULLUP, but sadly this particular pin does not have an internal pullup!

@JyeSmith JyeSmith merged commit 4664dcd into master Apr 14, 2023
76 checks passed
@JyeSmith JyeSmith deleted the fix-ttgo-power-creep branch April 14, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants