Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable processing MSPVTX commands if there is not SPIVTX #2525

Merged
merged 2 commits into from Jan 21, 2024

Conversation

pkendall64
Copy link
Collaborator

MSP VTX should only operate and send the VTX table if the receiver actually has a VTX.
The fix is to initialise the state machine in the STOPPED state and only enter the waiting state if there is an SPI VTX configured in the hardware layout.
Fixes #2452

@phobos-
Copy link
Member

phobos- commented Jan 5, 2024

Looks ok, I'll test with the hardware shortly and let you know if it works as it should with an RTC6705 attached.

Copy link
Member

@phobos- phobos- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a VTX - works OK.

@JyeSmith JyeSmith merged commit 212361b into ExpressLRS:master Jan 21, 2024
40 checks passed
zeebrababrik pushed a commit to zeebrababrik/ExpressLRS that referenced this pull request Jan 23, 2024
@pkendall64 pkendall64 deleted the fully-disable-mspvtx branch February 1, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VTX table is erased in BF lua script when using ELRS 3.3
3 participants