Add file drag-and-drop to webui update tab #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadbytefpv
force-pushed
the
dbWebUIupload
branch
from
bdc3c52
to
aef9306
Compare
deadbytefpv
changed the title
pkendall64
reviewed
Mar 15, 2024
pkendall64
approved these changes
Mar 16, 2024
wvarty
approved these changes
Mar 19, 2024
mha1
pushed a commit
to mha1/ExpressLRS
that referenced
this pull request
Mar 21, 2024
* Add file drag-and-drop to update tab * Refactored File Handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope it's much clearer now you can drag-and-drop the firmware file to update.
Selecting or Dropping the Firmware File starts the upload automatically and if the file is a valid firmware file, firmware update should start as normal.
Tested with a Vantac TX and RX.
Test Method:
Build new firmware to be flashed into the devices.
Activate wifi mode on device. Load their WebUI. Go into Update Tab. Build a firmware (version doesn't matter much).
Failure mode tested by uploading a TX firmware into RX device, and RX firmware into a TX device. User should still be able to reupload file.
Success mode tested by uploading the appropriate firmware file into their respective device. Terminates as before.