SBUS: failsafe mode Last Position stops SBUS output #2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mha1
requested review from
pkendall64,
CapnBry and
JyeSmith
and removed request for
JyeSmith
pkendall64
approved these changes
May 17, 2024
CapnBry
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In a failsafe situation (i.e. disconnected state) the status of frameMissed and frameAvailable is false. This leads to skipping the output of SBUS frames in a failsafe situation with failsafe mode Last Position selected.
Solution:
Extend the logic for skipping an SBUS frame to take the failsafe state in account. Now SBUS frames will be output with frozen data (last position), the failsafe bit set and at 9ms interval.