Preflight fails if getFreeDiskSpace returns false

[ssssct]

Description of the problem

When you update EE6, the process will stop on preflight if it can’t figure out the available disk space. On shared hosting the available disk space can be hidden so the disk_free_space($path) PHP function will return FALSE preventing the live update to run even if it could.

getFreeDiskSpace() in Filesystem.php, is using disk_free_space($path) which can either return a float or FALSE, but in checkDiskSpace() in Preflight.php the returned value is treated as a number so if it gets FALSE, it fails assuming there is 0 available disk space.

Environment Details:

• Version: 6.x
• PHP Version any

Possible Solution

system/ee/ExpressionEngine/Service/Updater/Downloader/Preflight.php

Line 94
if ($free_space < 52428800) {

This line should take into account that $free_space can be FALSE
Maybe just warn or prompt the user to decide if he wants to proceed anyway?