Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes <generator> tag output when there are no results #1189

Merged
merged 1 commit into from Oct 12, 2021
Merged

Removes <generator> tag output when there are no results #1189

merged 1 commit into from Oct 12, 2021

Conversation

iammattmartin
Copy link
Contributor

@iammattmartin iammattmartin commented Jul 5, 2021 •
edited

Overview

Fixes #1139

Removes the tag on feeds that have no content to stop data disclosure as to version of EE in use.

Nature of This Change

  • 馃敀 Improves security

@CLAassistant
Copy link

CLAassistant commented Jul 5, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@iammattmartin iammattmartin mentioned this pull request Jul 5, 2021
Closed
@intoeetive intoeetive added this to the 6.1.2 milestone Oct 8, 2021
intoeetive
intoeetive approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@intoeetive intoeetive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but also want to get opinion from @TomJaeger

@obfuscode obfuscode merged commit 8cf4be0 into ExpressionEngine:6.dev Oct 12, 2021
@iammattmartin iammattmartin deleted the rss-generator-removal branch October 13, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intoeetive intoeetive intoeetive approved these changes

@TomJaeger TomJaeger Awaiting requested review from TomJaeger

Assignees

@ops-andy ops-andy

Labels
None yet
Projects
None yet
Milestone
6.1.2
Development

Successfully merging this pull request may close these issues.

Remove EE default generator tag.
5 participants
@iammattmartin @CLAassistant @intoeetive @obfuscode @ops-andy