Resolved an issue where the author filter could have a missing label. #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no screen name was set, you'd end up with author filters on edit entries and files where nothing showed in cases where screen name was missing. You could also throw a php error in php 8.1+ ```htmlentities(): Passing null to parameter #1 ($string) of type string is deprecated ee/ExpressionEngine/Service/Filter/Filter.php, line 227```
robinsowell
added
the
Bug: Accepted
robinsowell
added a commit
that referenced
this pull request
Feb 13, 2023
If no screen name was set, you'd end up with author filters on edit entries and files where nothing showed in cases where screen name was missing. You could also throw a php error in php 8.1+ htmlentities(): Passing null to parameter #1 ($string) of type string is deprecated ee/ExpressionEngine/Service/Filter/Filter.php, line 227 see also #2848
intoeetive
previously approved these changes
Feb 14, 2023
intoeetive
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no screen name was set, you'd end up with author filters on edit entries and files where nothing showed in cases where screen name was missing.
You could also throw a php error in php 8.1+