Changing a custom field type now resets the field settings. #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, it just left the settings, which really shouldn’t have mattered. But it was causing Asset fields to continue to display as Asset fields on publish, even after changing to File fields. The setting fields also didn’t display on the file field’d edit page. Cleaning them out on save just makes sense.
obfuscode
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, it just left the settings, which really shouldn’t have mattered. But it was causing Asset fields to continue to display as Asset fields on publish, even after changing to File fields. The setting fields also didn’t display on the file field’d edit page. Fixes #618
Cleaning them out on save just makes sense.
Is this backwards compatible?