Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add an input to enter exact number of item in inventory. #31

Closed
Akenaide opened this issue Jun 8, 2020 · 4 comments
Closed

Comments

@Akenaide
Copy link

Akenaide commented Jun 8, 2020

Hello, thanks for your great work.

Is your feature request related to a problem? Please describe.

The inventory feature is really great and i'd like to point something.

When I'm grinding I update the items in the inventory, if it's a new item the quick increment are enough (thoses https://i.imgur.com/wiQB9Ej.png) but if it's an "old" item and I discover that I have a bunch I need to open the inventory search the right item and update.

I found this process tiring after few runs.

Describe the solution you'd like

I think adding a input in the same pop up than the quick increment will improve this use case.

Describe alternatives you've considered

Maybe using replace instead of increment when you use the add item page in the inventory will be enough so people can update their items without checking and updating if they have it or adding if not.

@Expugn
Copy link
Owner

Expugn commented Jun 8, 2020

I will consider adding an input on the pop up, thank you for the suggestion.
Another alternative you should consider is that clicking the item you want to edit in your inventory list lets you edit the amount you have, as shown in the image below if you didn't know that.
Capture

@Akenaide
Copy link
Author

Akenaide commented Jun 9, 2020

Thanks you.

Yes, I'm aware. This is what I meant when I said "I need to open the inventory search the right item and update."

I don't think it's enough because you need to open and search in the inventory when it would be easier to update in the quest list (and the quick increment is a good idea) and the items's order in the inventory is not always the same as in game (eg when you add a previously out of stock item it will be shown at the end).

Expugn added a commit that referenced this issue Jun 10, 2020
- Suggested by Akenaide (#31)

Read the CHANGELOG.md for more information
@Expugn
Copy link
Owner

Expugn commented Jun 10, 2020

Your suggested feature has been added here: ae21a35

To open the input, you can click on your current inventory amount (or anywhere that's the dark transparent rectangle).
After making changes to the input, you can press the OK button or your ENTER key (while the input is selected) to make your changes.
Capture

@Expugn Expugn closed this as completed Jun 10, 2020
@Akenaide
Copy link
Author

Thanks you o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants