Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow motorbikes to be ownable #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow motorbikes to be ownable #7

wants to merge 1 commit into from

Conversation

AntumDeluge
Copy link
Contributor

@AntumDeluge AntumDeluge commented May 29, 2021 •
edited
Loading

Makes use of setting mount_ownable:

  • if enabled, players can only take or ride motorbike if their name matches the owner attribute

@AntumDeluge
Copy link
Contributor Author

AntumDeluge commented May 29, 2021 •
edited
Loading

I've found some more issues that I want to fix. I am going to close this & re-submit in another pull request with other fixes.

Edit: Oops, meant to do that in #5.

@AntumDeluge AntumDeluge reopened this May 29, 2021
@AntumDeluge
Copy link
Contributor Author

If #8 is accepted, I will need to rebase this.

@AntumDeluge
Copy link
Contributor Author

Rebased.

@Extex101
Copy link
Owner

Yep just have it off by default though, most vehicle mods don't have ownable vehicles so I think it's best to just keep it off

@AntumDeluge
Copy link
Contributor Author

just have it off by default

Sure.

most vehicle mods don't have ownable vehicles

helicopter is the only one I am aware of. I created a PR for bicycle like this one.

@AntumDeluge
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AntumDeluge @Extex101