Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Email Notifications for Available Updates from Node #191

Merged
merged 2 commits into from Apr 14, 2024

Conversation

ExtremeFiretop
Copy link
Owner

Disable Email Notifications for Available Updates from Node
Primary now handles these updates notifications for the nodes.

Even if they want notifications enabled on the node for flashing, unzip errors, ect, they shouldn't be receiving the update available notifications.

@Martinski4GitHub
Copy link
Collaborator

Disable Email Notifications for Available Updates from Node Primary now handles these updates notifications for the nodes.

Even if they want notifications enabled on the node for flashing, unzip errors, ect, they shouldn't be receiving the update available notifications.

That's a good point. But now I'm wondering if that's something that should be a user-configurable option in "Advanced Settings" (shown only for Mesh Nodes, with FALSE as the default) because I'd bet that some user(s) out there will ask to be able to receive email notifications for everything for some reason (e.g. the scheduled cron job runs at different times with shorter interval than the Main router so the update notifications would be received sooner). Just a thought.

@ExtremeFiretop
Copy link
Owner Author

Disable Email Notifications for Available Updates from Node Primary now handles these updates notifications for the nodes.
Even if they want notifications enabled on the node for flashing, unzip errors, ect, they shouldn't be receiving the update available notifications.

That's a good point. But now I'm wondering if that's something that should be a user-configurable option in "Advanced Settings" (shown only for Mesh Nodes, with FALSE as the default) because I'd bet that some user(s) out there will ask to be able to receive email notifications for everything for some reason (e.g. the scheduled cron job runs at different times with shorter interval than the Main router so the update notifications would be received sooner). Just a thought.

I had thought about this already. but I couldn't see a reason or use-case myself so I decided to opt for this.
It would add another option in the advanced options which would likely be unused, I'd probably wait until someone asks for this as a feature myself and then re-assess based on why they might be requesting this in the first place.

@ExtremeFiretop
Copy link
Owner Author

Disable Email Notifications for Available Updates from Node Primary now handles these updates notifications for the nodes.
Even if they want notifications enabled on the node for flashing, unzip errors, ect, they shouldn't be receiving the update available notifications.

That's a good point. But now I'm wondering if that's something that should be a user-configurable option in "Advanced Settings" (shown only for Mesh Nodes, with FALSE as the default) because I'd bet that some user(s) out there will ask to be able to receive email notifications for everything for some reason (e.g. the scheduled cron job runs at different times with shorter interval than the Main router so the update notifications would be received sooner). Just a thought.

I guess the way I saw it was the primary reporting the status of the nodes wasn't made optional, so the nodes reporting themselves probably shouldn't be made optional, unless we made it all optional.

@Martinski4GitHub
Copy link
Collaborator

Disable Email Notifications for Available Updates from Node Primary now handles these updates notifications for the nodes.
Even if they want notifications enabled on the node for flashing, unzip errors, ect, they shouldn't be receiving the update available notifications.

That's a good point. But now I'm wondering if that's something that should be a user-configurable option in "Advanced Settings" (shown only for Mesh Nodes, with FALSE as the default) because I'd bet that some user(s) out there will ask to be able to receive email notifications for everything for some reason (e.g. the scheduled cron job runs at different times with shorter interval than the Main router so the update notifications would be received sooner). Just a thought.

I guess the way I saw it was the primary reporting the status of the nodes wasn't made optional, so the nodes reporting themselves probably shouldn't be made optional, unless we made it all optional.

OK, that sounds good. Let's wait for a user request to make the Mesh Nodes notifications user-configurable.

@Martinski4GitHub Martinski4GitHub merged commit 6b1be75 into dev Apr 14, 2024
1 check passed
@ExtremeFiretop ExtremeFiretop deleted the ExtremeFiretop-patch-1 branch April 14, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants