Mentor mentee view temp #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2736) (expertiza#2742) * Update list_submissions.html.erb * Update list_submissions.html.erb * Display grade assignment when assignment is finished
…ses the partial name correctly. Added an html view for the emails being sent to users when added to teams. Added functionality such that mentored teams users get emails when added to teams. Lastly, added functionality such that the mentor gets a separate email letting them know they are mentoring a team now (there was already working functionality letting users know when a mentor is added to their team).
…displayed correctly.
…entors to be emailed when added to groups. Implemented new way for mentors to be emailed. Added html files for mentor added to group emails. Added an if statement to check whether a user is a mentor or not so they get the right email. Yes I would not do I type check if I didn't have to. However, since mentors are not of a different class than users, I can't actually use polymorphism to fix this issue unless I add an entire new mentor class to the system, which would be far out of the scope of this project.
…l when nil assignment ids were sent to add teams, and another random error where "participants" are sent as a user to add_teams. Apparently this is used for some other feature on Expertiza, but I'm not sure what. As it's outside the scope of this project I just added a type check so that "participants" aren't sent the email other users are. Also added tests for the new mailing functions.
…entor-mentee-view-temp
…/expertiza into mentor-mentee-view-temp
…/expertiza into mentor-mentee-view-temp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please set the title of your pull request in the following format:
[Project id/Independent study/Issue fix/...]. project name, eg.,E904. Integrating courses and assignments on Expertiza with MoodleWe suggest you including the below information in your pull request:
About the Expertiza Bot
/dispute [UUID1] [UUID2](example), then the professor and TAs will be notified.