Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataTable] Refresh visible columns #150

Merged
merged 5 commits into from Jul 1, 2020
Merged

[DataTable] Refresh visible columns #150

merged 5 commits into from Jul 1, 2020

Conversation

SferaDev
Copy link
Contributor

@SferaDev SferaDev commented May 4, 2020 •
edited by tokland

@SferaDev SferaDev self-assigned this May 4, 2020
xurxodev
xurxodev approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@xurxodev xurxodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SferaDev, I have tested in MetadataSync for my scenario and works.

@xurxodev xurxodev mentioned this pull request May 4, 2020
Merged
27 tasks
@SferaDev SferaDev changed the base branch from fix/data-table-urls to development May 8, 2020 10:27
@SferaDev SferaDev changed the title [Fix] Refresh visible columns [DataTable] Refresh visible columns May 20, 2020
tokland
tokland approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Tested in project-monitoring-app, works fine!

@SferaDev
Copy link
Contributor Author

Fast-forwarded to development and published 1.4.3-beta.1

@adrianq adrianq merged commit a3759c4 into development Jul 1, 2020
@SferaDev SferaDev deleted the fix/refresh-visible-columns branch July 1, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokland tokland tokland approved these changes

@xurxodev xurxodev xurxodev approved these changes

@adrianq adrianq Awaiting requested review from adrianq

Assignees

@SferaDev SferaDev

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@SferaDev @tokland @xurxodev @adrianq