Feature/create home page #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now routes used in root and routes used by goTo is the same
Base automatically changed from
feature/improve_architecture_and_create_tests
to
development
June 24, 2020 07:32
ifoche
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃搶 References
馃摑 Implementation
The goal is to create a home page similar to MetadataSync app.
I have created the landing page.
I have refactored the goTo and useGoTo functions. Now, this functions is in root component file and routes paths are defined one time for Router and goTo.
馃帹 Screenshots
馃敟 How to test it? (If there is any special consideration or the reviewer does not know how to test it)
use case 1: To start the app the home page should be default page
use case 2: Import page should have back button to back to home page
use case 3: Navigation from import page to mapping pages should work as febore
馃搼 Others