Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost quoting for command line arguments #353

Open
holstgr-kaust opened this issue Aug 3, 2014 · 1 comment
Open

Lost quoting for command line arguments #353

holstgr-kaust opened this issue Aug 3, 2014 · 1 comment

Comments

@holstgr-kaust
Copy link

There is an issue with lost quoting using Equalizer apps. For example:

app --arg="quoted∧quoted"

Will become:

ssh ... 'app --arg=quoted∧quoted' ...

Instead of:

ssh ... 'app --arg="quoted∧quoted"' ...

As a result, the app will not run the same way on the different nodes, and various arguments will run as commands and fail.

The 'ssh' command is created in _createRemoteCommand and _launch in Equalizer/eq/server/node.cpp using the SATTR_LAUNCH_COMMAND and CATTR_LAUNCH_COMMAND_QUOTE formatting strings in Equalizer/eq/server/global.cpp.

@eile
Copy link
Member

eile commented Aug 4, 2014

I think the shell already removes the quotes, so Eq never sees them. We probably need to quote each argument?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants