Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive memory usage with push and no CO_AGRESSIVE_CACHING #82

Closed
eile opened this issue Jan 10, 2012 · 1 comment
Closed

Excessive memory usage with push and no CO_AGRESSIVE_CACHING #82

eile opened this issue Jan 10, 2012 · 1 comment
Assignees
Milestone

Comments

@eile
Copy link
Member

eile commented Jan 10, 2012

Memory usage goes to ~4GB and then drops down to 2.7GB after a couple of frames. Collage aggressive caching is off, so it should never go above 2.7GB

@ghost ghost assigned eile Jan 10, 2012
@eile eile closed this as completed in 8a402f3 Jan 10, 2012
@eile
Copy link
Member Author

eile commented Jan 19, 2012

Re-opening. The CommandCache still consumes lots of memory.

@eile eile reopened this Jan 19, 2012
eile added a commit that referenced this issue Jan 19, 2012
[ ] May break build
[ ] May break existing applications (see CHANGES.txt)
[x] Bugfix
[ ] New Feature
[ ] Cleanup
[ ] Optimization
[ ] Documentation
dulley added a commit to rttag/Equalizer that referenced this issue Jan 23, 2012
…s it received large data again (co/commandCache.cpp).Picked some changes from EQ master as well.

[ ] May break build
[ ] May break existing applications (see CHANGES.txt)
[x] Bugfix
[ ] New Feature
[ ] Cleanup
[ ] Optimization
[ ] Documentation
@eile eile closed this as completed in da9b186 Jan 24, 2012
eile added a commit that referenced this issue Feb 10, 2012
This was a race introduced by #82:

[rcv thread]
_handleData:
  dispatchCommand to instance1
    enqueue to foo thread

[foo thread]
  process command
  release command

[rcv thread]
  dispatch the same command to instance2
    cloneCommand
      compact cache
      free command [yee-ha!]

Fix by retaining the command during dispatch.

[ ] May break build
[ ] May break existing applications (see CHANGES.txt)
[x] Bugfix
[ ] New Feature
[ ] Cleanup
[ ] Optimization
[ ] Documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant