Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for audio in reload #115

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Support for audio in reload #115

merged 1 commit into from
Aug 16, 2023

Conversation

Sgtfishtank
Copy link
Contributor

@Sgtfishtank Sgtfishtank commented Aug 14, 2023

When using this library with Eyevinn Channel Engine with live-mix e.g. mixing a live stream with a vod. When CE is switching from live -> V2L, it uses the reload function in this library to supplement it with the live segments.

This PR is solving that the reload function does not handle additional audio segments by implementing support for additional audio segments on reload.

@Sgtfishtank Sgtfishtank marked this pull request as ready for review August 14, 2023 22:17
Copy link
Collaborator

@Nfrederiksen Nfrederiksen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Nfrederiksen Nfrederiksen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birme birme merged commit e6a0ad0 into master Aug 16, 2023
4 checks passed
@birme birme deleted the support-for-audio-in-reload branch August 16, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants